<html>
<head><meta charset="utf-8"><title>re: Draft CI · t-infra · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/index.html">t-infra</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/re.3A.20Draft.20CI.html">re: Draft CI</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="209049662"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/re%3A%20Draft%20CI/near/209049662" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jubilee <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/re.3A.20Draft.20CI.html#209049662">(Sep 04 2020 at 02:26)</a>:</h4>
<p>re: <a href="https://github.com/rust-lang/rust/pull/76272">https://github.com/rust-lang/rust/pull/76272</a></p>
<p>Obvious options</p>
<ol>
<li>always run CI on drafts (current)</li>
<li>never run CI on drafts (with that PR)</li>
<li>opt-out CI on drafts (proposed by <a href="https://github.com/rust-lang/rust/pull/76272#issuecomment-686600591">https://github.com/rust-lang/rust/pull/76272#issuecomment-686600591</a>)</li>
<li>opt-in CI on drafts (proposed by <a href="https://github.com/rust-lang/rust/issues/67357#issuecomment-566252404">https://github.com/rust-lang/rust/issues/67357#issuecomment-566252404</a>)</li>
</ol>
<p>additionally: Regardless, probably review the rules for rust-log-analyzer and such?</p>
<p>I am more-or-less fine with Always and Never because I think either rule is... principled? About Opt In or Opt Out, honestly thinking about it a bit longer I would be against Opt In, as it would become Another Thing To Learn on the most forward-facing element of contributing, so it works more against people the newer they are. Inconsistencies should generally run the other direction.</p>



<a name="209049829"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/re%3A%20Draft%20CI/near/209049829" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/re.3A.20Draft.20CI.html#209049829">(Sep 04 2020 at 02:31)</a>:</h4>
<p>there's also the fact that marking it 'draft' is in itself an opt-in</p>



<a name="209049869"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/re%3A%20Draft%20CI/near/209049869" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/re.3A.20Draft.20CI.html#209049869">(Sep 04 2020 at 02:32)</a>:</h4>
<p>if you want people to see it's a draft but not machines, you can add <code>[WIP]</code> or something</p>



<a name="209050362"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/re%3A%20Draft%20CI/near/209050362" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/re.3A.20Draft.20CI.html#209050362">(Sep 04 2020 at 02:47)</a>:</h4>
<p>I am still not seeing benefits to changing anything here personally - seems like CI running can only help folks out. I wouldn't want to complicate our configuration for this I think.</p>



<a name="209050473"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/re%3A%20Draft%20CI/near/209050473" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jubilee <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/re.3A.20Draft.20CI.html#209050473">(Sep 04 2020 at 02:50)</a>:</h4>
<p>Any decision resolves the issue, so that Would Also Be Fine. <span aria-label="musical notes" class="emoji emoji-1f3b6" role="img" title="musical notes">:musical_notes:</span></p>



<a name="209074269"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/re%3A%20Draft%20CI/near/209074269" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/re.3A.20Draft.20CI.html#209074269">(Sep 04 2020 at 09:51)</a>:</h4>
<p>I think running it always but turning RLA off could be a good compromise</p>



<a name="209086674"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/re%3A%20Draft%20CI/near/209086674" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> DPC <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/re.3A.20Draft.20CI.html#209086674">(Sep 04 2020 at 12:19)</a>:</h4>
<p>i was wondering, if we should defer on assigning reviewers to draft prs. Maybe have highfive assign a reviewer only when a pr is converted from draft -&gt; ready.  Or at least label it as s-waiting-on-author till a draft pr is marked as ready</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>